summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorScott Bahling <sbahling@suse.de>2016-02-21 12:54:59 +0100
committerScott Bahling <sbahling@suse.de>2016-02-21 12:54:59 +0100
commit3269f3b00c8c7fe1d3fcf52726f2dae27b62d830 (patch)
treea8e19d420687e8b08a0614b9da92f5c80d3ffb46
parent96e67da70b43c911036cb2dd5a2a05b7e0a27095 (diff)
downloadobsapi-3269f3b00c8c7fe1d3fcf52726f2dae27b62d830.tar.gz
obsapi-3269f3b00c8c7fe1d3fcf52726f2dae27b62d830.tar.xz
obsapi-3269f3b00c8c7fe1d3fcf52726f2dae27b62d830.zip
rename get_binaries to binaries_ls
Consistency with the other "ls" methods
-rw-r--r--obsapi/core.py6
-rw-r--r--test/test_api.py14
2 files changed, 16 insertions, 4 deletions
diff --git a/obsapi/core.py b/obsapi/core.py
index e46e57f..55ddba0 100644
--- a/obsapi/core.py
+++ b/obsapi/core.py
@@ -246,7 +246,9 @@ class ObsApi(object):
def put_package_meta(self, prj, pkg, xml):
return self.put_meta(prj, pkg, xml)
- def ls(self, prj=None, pkg=None):
+ def ls(self, prj=None, pkg=None, repo=None, arch=None):
+ if repo and arch:
+ return self.binaries_ls(prj, pkg, repo, arch)
if prj and pkg:
return self.package_ls(prj, pkg)
if prj:
@@ -295,7 +297,7 @@ class ObsApi(object):
return sinfo
- def get_binaries(self, prj, pkg, repo, arch):
+ def binaries_ls(self, prj, pkg, repo, arch):
api = '/build/{}/{}/{}/{}'.format(prj, repo, arch, pkg)
xml = self.get_xml(api)
blist = etree.fromstring(xml)
diff --git a/test/test_api.py b/test/test_api.py
index 20787d4..17196a6 100644
--- a/test/test_api.py
+++ b/test/test_api.py
@@ -32,11 +32,21 @@ def test_ls_pkg():
assert f in items
-def test_get_binaries():
+def test_ls_binaries():
files = ['_statistics', 'rpmlint.log', 'suse-hello-1.0-2.1.src.rpm',
'suse-hello-kmp-default-1.0_k3.12.28_4-2.1.x86_64.rpm',
]
- listing = api.get_binaries(prj=prj, pkg=pkg, repo=repo, arch=arch)
+ listing = api.ls(prj=prj, pkg=pkg, repo=repo, arch=arch)
+ items = [i.filename for i in listing]
+ for f in files:
+ assert f in items
+
+
+def test_binaries_ls():
+ files = ['_statistics', 'rpmlint.log', 'suse-hello-1.0-2.1.src.rpm',
+ 'suse-hello-kmp-default-1.0_k3.12.28_4-2.1.x86_64.rpm',
+ ]
+ listing = api.binaries_ls(prj=prj, pkg=pkg, repo=repo, arch=arch)
items = [i.filename for i in listing]
for f in files:
assert f in items